Skip to content

Conversation

yhkaplan
Copy link

@yhkaplan yhkaplan commented Oct 12, 2020

Addresses the error below. It appears in Xcode 12 because 12 drops support for iOS 8.0. Going this far to update Package.swift, I might as well drop support in Cocoapods + Carthage for iOS 8.0....

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

libwebp-Xcode - Package.swift doesn't happen an explicit minimum deployment target, therefore it is set to iOS 9.0 in Xcode 12, causing the error above.

Possible Solutions

  1. Drop support for iOS 8 and make minimum deployment target iOS 9
  2. Explicitly make libwebp-Xcode - Package.swift supply iOS 8 as minimum deployment target

iOS 8 came out in 2014 and likely many app don't even support it anymore, so I think 1. makes more sense, but it should be a decision made project wide for each library under the SDWebImage instead of making changes in piecemeal, which would be more confusing.

Addresses the error below:

`The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.`
@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #45 into master will increase coverage by 1.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   81.07%   82.26%   +1.18%     
==========================================
  Files           2        2              
  Lines         761      761              
==========================================
+ Hits          617      626       +9     
+ Misses        144      135       -9     
Flag Coverage Δ
#ios 82.26% <ø> (+1.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SDWebImageWebPCoder/Classes/SDImageWebPCoder.m 82.16% <0.00%> (+1.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84c97db...40c3490. Read the comment docs.

@yhkaplan yhkaplan changed the title Fix SPM Error [WIP] Fix SPM Error Oct 12, 2020
@yhkaplan yhkaplan changed the title [WIP] Fix SPM Error [WIP] Fix Xcode 12 Warning Oct 12, 2020
@yhkaplan yhkaplan changed the title [WIP] Fix Xcode 12 Warning [WIP] Fix Xcode 12 SPM Error Oct 12, 2020
@dreampiggy
Copy link
Contributor

Actually, another solution:

change libwebp's min deployment target version: SDWebImage/libwebp-Xcode#5

@dreampiggy
Copy link
Contributor

dreampiggy commented Oct 12, 2020

But libwebp need Google team to release another version. I can not Release a libwebp version where Google official source repo does not contains.

So things suck.

See more: https://groups.google.com/a/webmproject.org/g/webp-discuss/c/bAxEA6MW8ug


Seems libwebp decide to release 1.2.0 in Q4. Should we wait for that ? Or I release a libwebp 1.1.1 patch version (where Google don't have one) ?

@dreampiggy
Copy link
Contributor

This been soved by #48

@dreampiggy dreampiggy closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants