Fix the Animated WebP render logic used by SDAnimatedImageView. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent code do extra cost. Refactor it with more simple logic.
dreampiggy
force-pushed
the
bugfix_webp_animtion_render_logic
branch
from
715cee4 to
02595bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code do extra cost. Refactor it with more simple logic.
I update the comment here to show what these code do. It's a performance enhancement to avoid loop through from 0 to follow WebP standard.
The WebP standard pseudocode for Animation rendering: https://developers.google.com/speed/webp/docs/riff_container#metadata