Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Show/Hide Columns and Reorder Columns to Building Detail #577

Closed
RDmitchell opened this issue Dec 16, 2015 · 15 comments
Closed

Add Show/Hide Columns and Reorder Columns to Building Detail #577

RDmitchell opened this issue Dec 16, 2015 · 15 comments
Assignees
Labels

Comments

@RDmitchell
Copy link

In the Building List, it is possible to control what fields are displayed in the list, and what order they are in, under the List Settings link. I am putting the main ideas about the new functionality directly into this issue, but am also starting a spec document where the developer who works on this can add more details. Here is a link to that doc:
https://docs.google.com/a/lbl.gov/document/d/1wCBzs5iJxNg0Hlg8Xhfzyjx2DXfhGf4GXCofMQdHNsU/edit?usp=sharing

This functionality would also be useful in the Building Detail view.

Show/Hide Columns feature in Building List
image

Reorder Columns Feature in Building List
image

Building Detail View
Add a List Settings link

  • This link would go to the same type of screens that the Building List goes to
    • Show/Hide Columns
    • Reorder Columns
  • These settings would need to be stored separately from the Building Detail settings so that the user could have different settings for the Building List and the Building Detail views.
  • These settings would controls what fields (and associated data) are shown on the left side of the screen, and what order the fields are in.

image

@RDmitchell
Copy link
Author

assigned to @danielmcquillen with help from Piper for BE issues as needed.

@nicholasserra
Copy link
Contributor

@RDmitchell Would these column preferences be different on each building, or apply to all buildings?

@RDmitchell
Copy link
Author

@nicholasserra -- if it is simpler to make the preferences apply to all buildings in the org, I would say we should start there. If, after users work with this, they decide they want to control it on a building by building basis, we can add that. I think in general, they just want to hide the fields that they don't use, so probably having the settings apply to all buildings is generally what people will want. thx.

@RDmitchell
Copy link
Author

@nicholasserra -- feel free to add to the spec if you think that is useful or necessary. Or just add comments directly into this issue. thx.

@nicholasserra
Copy link
Contributor

So this one is probably going to take a solid few days. The navigation bar (List settings, reports, labels) on the building list view was built differently than the navigation bar on the building detail page. Only reason that's an issue is because the building_settings_controller, which has all the column show hide and reordering, was built as a reusable view.

So my plan is to refactor the nav on the detail page a bit to use separate controllers per nav item, using their own urls. Then I can reuse the existing settings controller.

@RDmitchell
Copy link
Author

I suspected this might be complicated, wasn't sure what it would take to get it working. @danielmcquillen, @axelstudios -- any comments on Nick's approach?

@nicholasserra
Copy link
Contributor

@RDmitchell There seems to be two hidden screens on the building detail page. An "area" settings and a "contact" settings. Were these removed at some point? They would have been in the navigation. Wondering if I need to move these over too.

@RDmitchell
Copy link
Author

@nicholasserra -- yes those were removed quite a while ago. I would say we don't want them right now, so maybe add a note to them that you are not refactoring at this time ... ??? Does that make sense. I don't think we want to take the time to move them into the newly refactored world.

@nicholasserra
Copy link
Contributor

I'll just delete the files. They'll be in version control if we need them at some point.

@RDmitchell
Copy link
Author

sounds good, thx

mmclark added a commit that referenced this issue Feb 2, 2016
…-prefs

Issue #577 - Url based tabs on building detail page.
@nicholasserra
Copy link
Contributor

Progress update:

I have this working pretty nicely. Just have to get the details page table respecting the column order. Other than that, everything is working just like the settings for the building list page. Should have a PR in for this midday tomorrow.

@RDmitchell
Copy link
Author

great, thanks !

mmclark added a commit that referenced this issue Feb 3, 2016
…-preferences-2

Issue #577 - Building Detail show/hide/reorder columns
@nicholasserra
Copy link
Contributor

Reassigning for testing.

@RDmitchell
Copy link
Author

This works great ! Thanks !!!!

@nicholasserra
Copy link
Contributor

NICE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants