Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping screen only shows non-JSON blob fields #885

Closed
RDmitchell opened this issue Apr 1, 2016 · 11 comments
Closed

Mapping screen only shows non-JSON blob fields #885

RDmitchell opened this issue Apr 1, 2016 · 11 comments
Assignees
Labels

Comments

@RDmitchell
Copy link

On the last mapping screen, where you click the Save Mappings button and then the program proceeds to go into Matching mode, the program displays the mapped field names to the actual data, in list form. It seems like the program shows all fields except those in the extra_data field, which is the JSON blob.

I mapped a file where the only field I mapped that was not in extra_data was Tax Lot ID (all the others had field names that would force them to be put into the extra_data field) and the only field that was displayed was the Tax Lot ID field, and it took up the entire screen (!).

In this screen we should show all the fields that were in the previous mapping screen, whether or not they are in a JSON blob field.

This may not be quite so important after the data model restructuring, because there will be fewer fields in JSON blob fields, but whatever data is in those fields needs to be displayed on the final mapping screen

image

@RDmitchell RDmitchell added this to the June 2016 Release milestone Apr 1, 2016
@RDmitchell RDmitchell self-assigned this Apr 1, 2016
@RDmitchell
Copy link
Author

Get an example file together.

@RDmitchell RDmitchell modified the milestones: 1.5 Release (May 31, 2016), June 2016 Release May 4, 2016
@RDmitchell
Copy link
Author

Here is a link to an example file that should show this problem.

https://drive.google.com/a/lbl.gov/folderview?id=0B3fTKpZ9Dx7LOWlRd04wbjlVUXc&usp=sharing

@nicholasserra
Copy link
Contributor

This seems to only happen the first time a new extra_data field is introduced. I suspect it is related to how the Columns table works.

To show this, import the test file and specify new extra_data field names for the fields. If you then go back to mapping and hit save mappings again, they'll all be on the mapping screen.

@nicholasserra
Copy link
Contributor

I have a fix for this in progress.

@RDmitchell
Copy link
Author

Interesting ... and I think that makes sense, thinking back about my experiences with mapping.

Thanks for working on this !!

mmclark added a commit that referenced this issue May 8, 2016
Issue #885 - Refresh columns during mapping step
@RDmitchell
Copy link
Author

@nicholasserra -- I can't seem to import this test file into any of my test accounts on seedtest. I have tried 3 different ones (61, 11 and 86). They all seem to hang at 45% in the "Upload your building data" screen. This file only has 6 fields and 9 records, so it should upload quickly.

I will try importing other files and see if it is a more universal problem. If it is, I will make a new issue.

@RDmitchell
Copy link
Author

@nicholasserra -- this seems to be a more universal problem -- I can't upload the covered building sample data. I just tried it on seed production and it uploads within a few seconds. On seedtest it is stuck at 45%. I will make a new issue and come back to testing this issue when the import problem is fixed.

@RDmitchell
Copy link
Author

Miles restarted celery, now I am able to import files.

Now I can get to the mapping screen, and below is how I mapped the file

image

But now the program seems to hang at 0% mapping.
image

3 minutes in, still at 0%, no errors in console. am cancelling it.

@RDmitchell
Copy link
Author

@nicholasserra -- am handing this back to you because I can't get the test file to map. Could be another problem with seedtest, but decided to put this back in your queue. You can make a new issue if there is a problem with mapping.

@RDmitchell
Copy link
Author

am taking this back because I think the mapping problem is not related to this bug. When that is figured out I will test this.

@RDmitchell
Copy link
Author

Thanks Nick -- looks great !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants