1715 inv detail pop cols only #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nllong
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
This worked as expected. I'm sure it was by design, but it only looks for columns on the existing record. If you rerun "only show populated columns" on another record with different columns, then it will update the default view with the new columns. This is the behavior that I expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
See attached issue
What's this PR do?
Adds "Only Show Populated Columns" to inventory detail page.
NOTE: The current and historical states of a record are considered when looking for populated fields (as well as the extra data for each).
How should this be manually tested?
Test the new button works just like the one in the inventory list page.
What are the relevant tickets?
#1715
Screenshots (if appropriate)