Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2184 - Add 'None' data type for enabling rule.min to accept input value. #2185

Closed
wants to merge 5 commits into from

Conversation

lainsworth8801
Copy link
Contributor

@lainsworth8801 lainsworth8801 commented Apr 14, 2020

Any background context you want to provide?

Data quality check minimum value is not enabled to accept input value when a new rule without a data type defaulted.

What's this PR do?

Added 'None' as one of the data types for rule.min to be enabled to accept user input values;
Removed 'null' from min and max to accept 0 values when saving rule settings.

How should this be manually tested?

Create a custom rule that is not listed in default rule list -> navigate to data quality tab and click 'create a new rule' -> in the drop-down value, select the custom rule -> as the data_type column is cleared, min value tab/form disappears not allowing any input.

What are the relevant tickets?

#2184

Screenshots (if appropriate)

Screen Shot 2020-04-13 at 8 59 22 PM

Screen Shot 2020-04-13 at 8 59 34 PM

@coveralls
Copy link

coveralls commented Apr 14, 2020

Coverage Status

Coverage remained the same at 77.497% when pulling 613b900 on none_data_type_min into f18114e on develop.

@nllong nllong requested review from adrian-lara and removed request for RDmitchell and nllong April 14, 2020 17:05
@nllong
Copy link
Member

nllong commented May 14, 2020

@lainsworth8801 can you resolve these conflicts when you get a chance?

@lainsworth8801
Copy link
Contributor Author

@lainsworth8801 can you resolve these conflicts when you get a chance?

Yes! Thanks for letting me know.

lainsworth8801 and others added 2 commits May 14, 2020 09:52
@adrian-lara
Copy link
Contributor

Looking at the commits that were actual code changes (the ones that are not "Merge branch 'develop'..."), theses are the only two I see:

  1. Removed null value for min and max to accept 0 value
  2. Added 'None' data type for enabling rule.min to accept input value.

Both can be found in this PR

@adrian-lara adrian-lara deleted the none_data_type_min branch May 19, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants