patch(meters.py): handle mistyping #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-lara
reviewed
May 11, 2020
| @@ -41,6 +41,7 @@ def __init__(self, property_id, org_id, excluded_meter_ids, scenario_ids=None): | |||
| self._cache_factors = None | |||
| self._cache_org_country = None | |||
|
|
|||
| scenario_ids = scenario_ids if scenario_ids is not None else [] | |||
There was a problem hiding this comment.
I think we could also set the default for scenario_ids as [] when defining the parameters.
There was a problem hiding this comment.
I used this pattern because python's default parameters are only evaluated once when the function is defined, so dicts and lists can cause some surprising results if modified. Check this out here: https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments
There was a problem hiding this comment.
Ah ok - didn't realize this could have been an issue! 👍
adrian-lara
approved these changes
May 11, 2020
| @@ -41,6 +41,7 @@ def __init__(self, property_id, org_id, excluded_meter_ids, scenario_ids=None): | |||
| self._cache_factors = None | |||
| self._cache_org_country = None | |||
|
|
|||
| scenario_ids = scenario_ids if scenario_ids is not None else [] | |||
There was a problem hiding this comment.
Ah ok - didn't realize this could have been an issue! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small patch for mistyped query parameter. This isn't a current issue (ie it should not actually cause runtime exceptions) but is an error nonetheless.