-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2176 apiv3 users #2212
2176 apiv3 users #2212
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments from my first pass. I didn't look at any of the endpoints that were just a "move" within the issue, but let me know if any are worth a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more follow up comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved some previous comments. Tested the endpoints, and for the most part they look good! A few potential changes, and this'll be good to go.
@adrian-lara - it turns out for the UI to render the body field for "role" needs to say "string". My solution to keep the param optional was to case switch on "string" and if unchanged default the user to be a viewer following least privilege. Let me know if this works. |
Co-authored-by: Adrian Lara <30608004+adrian-lara@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome - thanks for making those changes!
Each of the Swagger page v3 User endpoints work as expected. Feel free to merge once tests pass.
Any background context you want to provide?
The effort to move to API v3 - specifically users
What's this PR do?
translates API v2 into v3 with auto schema helper
How should this be manually tested?
Use the
Try It
functionality rendered by the API page on SEED for v3What are the relevant tickets?
#2176