-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using selection tool for bsync validation #2240
Using selection tool for bsync validation #2240
Conversation
…n successful upload
@@ -21,7 +21,6 @@ | |||
* ng-switch-when="11" == Confirm Save Mappings? | |||
* ng-switch-when="12" == Error Processing Data | |||
* ng-switch-when="13" == Portfolio Manager Import | |||
* ng-switch-when="14" == Successful upload! [BuildingSync] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the outdated frontend code for importing buildingsync files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Manual testing listed above is working. Code changes seem mostly identical to the changes made to the bricr branch. Other than small tweaks like to the use case as well as -View method tweak bricr is using an previous version of DRF, I didn't notice any changes when diff'ing the files against bricr-dev.
Let me know if I missed any major differences worth reviewing, otherwise, this is good to merge. 👍
Any background context?
This is the sister-pr to #2234
What's this PR do?
Adds an extra step to validate schema and use case when importing BuildingSync files
Also removes some vestigial front-end code for the old buildingsync import flow.
How should this be manually tested?
These tests should probably be run with and without celery workers, ie in local config include/exclude these lines
When testing celery workers, it might be worth setting the log level to debug so messages can be seen:
celery ... -l debug
. Note that you WON'T see any messages when not running workersFiles for testing:
use_case_data2.zip
single valid file
buildingsync_v2_0_bricr_workflow_GOOD.xml
/validate_use_cases
single valid file with warnings
buildingsync_v2_0_bricr_workflow_WARNINGS.xml
single file bad use case
ex_1_missing_required.xml
sing file bad schema
ex_1_bad_schema.xml
sing file that can't be parsed
ex_1_malformed.xml
zip file all good
many_all_good.zip
zip file one bad
many_one_bad.zip
random api issues
These are some things to test if the validation api is down or we get an unexpected response.
building_sync/validation_client.py
where the request is being made. Changing it to something like1
should be sufficient (make sure you restart celery!). When uploading a buildingsync file it should fail saying it timed outvalidation_client.py
test a bad request by tweaking the API url, the default schema version or use case name (again remember to restart celery). These should all result in some sort of failure, and should be reported when trying to upload a buildingsync fileScreenshots (if appropriate)
Example failure
Example success
Issues
#2245