2259 refactor/api v3 label inventory

[macintoshpie]

What's this PR do?

Moves v2 /labels-taxlot and /labels-property views to v3

How should this be manually tested?

Test api/v3/labels_taxlot/ and api/v3/labels_property/ on swagger page

What are the relevant tickets?

#2259

[coveralls]

Coverage decreased (-0.2%) to 71.835% when pulling 5517fc8 on 2259-refactor/api-v3-label-inventory into 4c34903 on develop.

[adrian-lara]

Initial review notes:

• Perms look good!
• Empty inventory_ids and populated add_label_ids does nothing 💯
• Changes generally look good!

proposed changes:

• Delete “If omitted, the effect is applied to all properties”
• Empty inventory_ids and populated remove_label_ids does it to everything 😬
  • Maybe just error when inventory_ids are empty?

[macintoshpie]

Empty inventory_ids and populated remove_label_ids does it to everything

That's appears to be the intended effect, though it should limit itself to the removal of labels that are within the org. If this is not what we want then we can change that. I'll make this PR a draft until we decide what to do here.

[adrian-lara]

Empty inventory_ids and populated remove_label_ids does it to everything

That's appears to be the intended effect, though it should limit itself to the removal of labels that are within the org. If this is not what we want then we can change that. I'll make this PR a draft until we decide what to do here.

That's a good point - I could definitely imagine users wanting to just completely remove a label from their entire org's properties or tax lots.

Looking into the way it's used on the FE, inventory_ids are basically required since the Update Labels button isn't "activated" until records are checked on the inventory list page. Given that, I'd vote to keep the changes you have currently (also requiring it for the API endpoint). What do you think?

[macintoshpie]

I think that sounds good 👍

[adrian-lara]

LGTM! Thanks for making the final changes 🙏