Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2310 datasets v3 transition #2387

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

adrian-lara
Copy link
Contributor

@adrian-lara adrian-lara commented Aug 31, 2020

Any background context you want to provide?

Part of the effort to move FE and tests to v3 APIs

What's this PR do?

Update tests and frontend _services to use API v3 dataset endpoints

How should this be manually tested?

  • On the dataset list page, CRUD datasets
  • On the dataset detail page, CRD import_files
  • On the inventory detail meter page, upload GreenButton data, see a list of datasets
  • On any page, expand the left menu to view the count of datasets

What are the relevant tickets?

#2310

@coveralls
Copy link

Coverage Status

Coverage remained the same at 69.166% when pulling 7ca2b03 on 2310_datasets_v3_transition into d97ce5c on develop.

Copy link
Contributor

@macintoshpie macintoshpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

One note though, looking at the original issue it seems like we dont want to actually delete datasets (ie ImportRecords) when hitting the delete endpoint. But it looks like it's actually deleting them

EDIT: I was mistaken! Things work as expected. TIL about django's model Managers

@adrian-lara adrian-lara merged commit 3e93976 into develop Aug 31, 2020
@adrian-lara adrian-lara deleted the 2310_datasets_v3_transition branch August 31, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants