Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx brotli compression #4686

Merged
merged 3 commits into from
May 31, 2024
Merged

Nginx brotli compression #4686

merged 3 commits into from
May 31, 2024

Conversation

axelstudios
Copy link
Member

@axelstudios axelstudios commented May 30, 2024

What's this PR do?

  • Configures Nginx to automatically serve the pre-compressed .br versions of static assets if available
  • Enables on-the-fly brotli compression for responses (replacing gzip)
  • Moves the 5 font css files to a block that can be compressed without loading them individually
  • Updates all translation files

How should this be manually tested?

  • Run SEED via Nginx locally and:
    • Check that the responses show Content-Encoding: br
    • attempting to access an html file within the node_modules directory results in downloading the file rather than serving it (e.g. /static/node_modules/angular-dragula/index.html)
    • attempting to access a static seed html file serves it as text/html (e.g. /static/seed/partials/home.html)

@axelstudios axelstudios requested a review from kflemin May 30, 2024 20:00
@axelstudios axelstudios added the Enhancement Add this label if functionality was generally improved but not a full feature or maintentance. label May 30, 2024
@SEED-platform SEED-platform deleted a comment from github-actions bot May 30, 2024
@kflemin kflemin merged commit 4cae698 into develop May 31, 2024
9 checks passed
@kflemin kflemin deleted the task/brotli branch May 31, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Add this label if functionality was generally improved but not a full feature or maintentance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants