-
Notifications
You must be signed in to change notification settings - Fork 0
Adds ScreenScribe implementation to utils' logger #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@konstantinos-chronis ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to make the code more clear to read I propose the following
if($this->_omitMessage($level))
return false;
And then continue with the rest of the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how currently every scribe homogeneously handles its local logging level. Matter of taste I guess. I'll ask my inner coding-zen later.
@konstantinos-chronis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
smaller should be used here too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed. 👍 Happy now?
Adds a scribe to the utils' logger which prints every log statement onto the screen. This scribe will be used in
lmvc
to replace all the library's print-statements.Checklist
config.json
andsample-config.json