Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprite format specification #1317

Merged
merged 1 commit into from Sep 23, 2020
Merged

Sprite format specification #1317

merged 1 commit into from Sep 23, 2020

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Sep 9, 2020

Specification for the improved .sprite format discussed in #965 .

Some slight changes were made to the definition in the issue, so we should discuss them in this draft. @Vtec234 @TheJJ

@heinezen heinezen added area: renderer Concerns our graphics renderer area: assets Involved with assets (images, sounds, ...) documentation Involves the project documentation labels Sep 9, 2020
@heinezen heinezen requested a review from TheJJ September 9, 2020 21:18
@heinezen heinezen added this to In progress in documentation via automation Sep 9, 2020
@heinezen heinezen marked this pull request as draft September 9, 2020 21:19
@heinezen heinezen moved this from In progress to Under Review in documentation Sep 9, 2020
This was linked to issues Sep 9, 2020
Sprite definition format #965
Closed
Define scaling factor for sprites #1162
Closed
Create a better sprite format #697
Closed
TheJJ
TheJJ requested changes Sep 12, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
@heinezen heinezen force-pushed the sprite-format branch 4 times, most recently from 9cff2a1 to 8bdf8a0 Compare September 20, 2020 18:37
@heinezen heinezen marked this pull request as ready for review September 21, 2020 07:39
TheJJ
TheJJ requested changes Sep 22, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

close to the finish

doc/media/openage/sprite_format_spec.md Outdated Show resolved Hide resolved
doc/media/openage/sprite_format_spec.md Show resolved Hide resolved
TheJJ
TheJJ approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yey

@TheJJ TheJJ merged commit 8cff17b into SFTtech:master Sep 23, 2020
documentation automation moved this from Under Review to Done Sep 23, 2020
@heinezen heinezen deleted the sprite-format branch October 13, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ approved these changes

Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) area: renderer Concerns our graphics renderer documentation Involves the project documentation
Projects
documentation
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define scaling factor for sprites Sprite definition format Create a better sprite format
2 participants
@heinezen @TheJJ