Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy subsystem code #1550

Merged
merged 68 commits into from
Dec 15, 2023
Merged

Remove legacy subsystem code #1550

merged 68 commits into from
Dec 15, 2023

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented Sep 23, 2023 •
edited
Loading

Resolves #1533

  • Asset management (yes, there are 3 deprecated asset managers)
    • openage::AssetManager
    • openage::LegacyAssetManager
    • openage::presenter::AssetManager
  • Deprecated Coordinate types (libopenage/coord)
    • CoordManager
    • Deprecated transformations between types
  • Gamedata dummy classes (libopenage/gamedata)
  • Old gamestate
    • Game logic (libopenage/gamestate/old)
    • Unit handling (libopenage/unit)
  • Old input system (libopenage/input/legacy)
  • Old GUI (libopenage/gui)
  • Old renderer
    • Logic (libopenage/presenter/legacy)
    • Data classes (texure, etc.)
  • Old Terrain (libopenage/terrain)

@heinezen heinezen added improvement Enhancement of an existing component lang: c++ Done in C++ code code quality Does not alter behavior, but beauty of our code labels Sep 23, 2023
@heinezen heinezen force-pushed the legacy-remove branch 3 times, most recently from 59baf28 to 4f72edb Compare September 24, 2023 14:11
@heinezen heinezen mentioned this pull request Sep 24, 2023
Merged
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 21, 2023
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 21, 2023
@heinezen heinezen added the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 21, 2023
@SFTbot SFTbot removed the kevin-rebuild-pl0x instruct kevin to rebuild this pull request label Oct 21, 2023
TheJJ
TheJJ reviewed Oct 22, 2023
View reviewed changes
doc/code_style/mom.cpp Outdated Show resolved Hide resolved
doc/code_style/mom.cpp Outdated Show resolved Hide resolved
@heinezen heinezen force-pushed the legacy-remove branch 2 times, most recently from a99cd80 to 41baf0c Compare October 24, 2023 01:49
@heinezen heinezen force-pushed the legacy-remove branch 6 times, most recently from 34f145d to 7e8c9c6 Compare November 7, 2023 23:56
@heinezen heinezen marked this pull request as ready for review November 11, 2023 21:19
@heinezen heinezen force-pushed the legacy-remove branch 3 times, most recently from 2e51c9c to 4d3dc3f Compare November 11, 2023 22:33
@heinezen heinezen mentioned this pull request Nov 23, 2023
Merged
16 tasks
TheJJ
TheJJ reviewed Dec 11, 2023
View reviewed changes
Copy link
Member

@TheJJ TheJJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeey

libopenage/CMakeLists.txt Outdated Show resolved Hide resolved
libopenage/console/draw.cpp Outdated Show resolved Hide resolved
libopenage/console/console.cpp Outdated Show resolved Hide resolved
libopenage/gamestate/api/terrain.cpp Show resolved Hide resolved
libopenage/gamestate/event/spawn_entity.cpp Outdated Show resolved Hide resolved
libopenage/renderer/gui/integration/private/gui_texture.cpp Outdated Show resolved Hide resolved
libopenage/renderer/opengl/error.cpp Outdated Show resolved Hide resolved
libopenage/renderer/stages/terrain/terrain_chunk.cpp Outdated Show resolved Hide resolved
libopenage/renderer/stages/terrain/terrain_mesh.cpp Show resolved Hide resolved
libopenage/util/profiler.cpp Outdated Show resolved Hide resolved
@heinezen
gui: Remove remaining mentions of SDL.
83b16da
@heinezen
engine: Fix capture of argument in thread function.
9d6a038
@heinezen
renderer: Use correct world space transformation for terrain model.
eb84b4c
@heinezen
doc: Update run instructions.
fd7f28a
@heinezen
gamestate: Terrain tile definition.
e1eee5e
@heinezen
gamestate: Replace terrain height map with tiles.
1f7ea14
@heinezen
terrain: Remove old terrain code.
520ca99
@heinezen
util: Remove CSV reader.
1718b67
@heinezen
renderer: Remove unused animation class.
040ead8
@heinezen
Fix CI complaints.
0462af2
@heinezen
Fix clang complaints.
547a5f2
@heinezen
util: Make type hint Python 3.9 compliant.
5f0865e
@heinezen
console: Fix comment formatting.
252076e
@heinezen
buildsys: Remove obsolte comment.
7b2b1fe
@heinezen
gamestate: Fix comment about static test entities.
be76f54
@heinezen
gamestate: Pass game entity ptr by reference.
7f4706e
@heinezen
gamestate: Make 'Player' moveable.
892ceb7
@heinezen
gamestate: Pass terrain chunk by reference.
9d4c3ba
@heinezen
gamestate: Fix missing std::move.
d635189
@heinezen
input: Pass controllers by reference.
8d779ed
@heinezen
pathing: Remove obsolete method.
0e70ea8
@heinezen
gui: Remove obsolete method.
21cffdb
@heinezen
renderer: Remove specific command hint.
11075b0
@heinezen
renderer: Remove reinterpret cast from memcpy operations.
ca35303
@heinezen
util: Remove obsolete classes.
5ae997b
@heinezen
renderer: Comment out currently unused param.
d07c460
@heinezen
fix comment indent with tabs.
10bc91d
@TheJJ TheJJ merged commit d0d9a4b into SFTtech:master Dec 15, 2023
12 of 13 checks passed
@heinezen heinezen deleted the legacy-remove branch February 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJJ TheJJ TheJJ left review comments

Assignees
No one assigned
Labels
code quality Does not alter behavior, but beauty of our code improvement Enhancement of an existing component lang: c++ Done in C++ code
Projects
openage code quality
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove legacy subsystem code
3 participants
@heinezen @TheJJ @SFTbot