Always use CWD as DLL search path on Windows #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heinezen
added
os: windows
heinezen
force-pushed
the
fix/dll_search_path
branch
from
ccfe703
to
6a7ad9a
Compare
TheJJ
reviewed
Feb 24, 2024
|
Didn't thought about that and I see your point. I changed it, so that the path of the directory of |
|
guess so, if the dll is in that dir? let's see if it helps :) |
TheJJ
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command working directory is now always used as a search path, even if
--add-dll-search-pathis not specified in the CLI.This should fix or mitigate issues like #1624 .