New features for job manager and integration into dynamic audio loading. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrekupka
added
lang: c++
|
The build fails with gcc 4.8.1 because of the thread_local thread_id in thread_id.cpp. With gcc 4.8.2 it builds without any problems. Clang doesn't complain either. |
|
Hopefully the newer compiler version will be available once travis-ci/travis-ci#979 is fixed. The currently used ubuntu toolchain ppa does not provide We either have to find another ppa, build it ourself (but the ppa system is nasty...) or wait for travis to provide a newer distro. |
|
I think switching to a different PPA would be best. If all else fails, we could add it to our custom sfttech PPA. |
| @@ -17,17 +17,14 @@ namespace audio { | |||
|
|
|||
| void global_audio_callback(void *userdata, uint8_t *stream, int len); | |||
|
|
|||
| AudioManager::AudioManager(int freq, SDL_AudioFormat format, uint8_t channels, | |||
| uint16_t samples) | |||
| AudioManager::AudioManager() | |||
| : | |||
There was a problem hiding this comment.
one tab indent for initializer list pls
added 25 commits
February 28, 2015 17:30
|
Looking good now 👍 |
andrekupka
pushed a commit
that referenced
this pull request
Feb 28, 2015
New features for job manager and integration into dynamic audio loading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added some features to the job manager.
Further I have integrated the new job groups into the dynamic audio loading implementation.