Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/libarchive loader #1314

Merged
merged 4 commits into from
Sep 23, 2022
Merged

Feature/libarchive loader #1314

merged 4 commits into from
Sep 23, 2022

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Sep 23, 2022

Proposed Changes

Types of changes

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update (if none of the other choices apply)
    • In this case, ensure that the message of the head commit from the source branch is prefixed with [skip ci]

Checklist

By opening this PR, I confirm that I have:

  • Reviewed the contributing guidelines for this repository
  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Updated any relevant API documentation
  • Created or updated any tests if relevant
  • Created a news file
    • NOTE: This must include any changes to any of the following files: default.yaml, any of the RabbitMQ server configurations, GlobalOptions.cs
  • Listed myself in the CONTRIBUTORS file 🚀
  • Requested a review by one of the repository maintainers

Issues

If relevant, tag any issues that are expected to be resolved with this PR. E.g.:

@jas88 jas88 requested a review from tznind September 23, 2022 15:26
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2022

This pull request introduces 2 alerts when merging a7bf91e into 119d1ff - view on LGTM.com

new alerts:

  • 2 for Use of default ToString()

@jas88 jas88 merged commit 82c6934 into master Sep 23, 2022
@jas88 jas88 deleted the feature/libarchive-loader branch September 23, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading 7z compressed archives failing in NHS-side (HIC) deployment
2 participants