Skip to content

Twig #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2020
Merged

Twig #146

merged 3 commits into from
Aug 1, 2020

Conversation

SMillerDev
Copy link
Owner

This rewrites almost all rendering to be seperate from the parsing and moves to Twig templates

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2020

Codecov Report

Merging #146 into master will increase coverage by 2.07%.
The diff coverage is 84.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #146      +/-   ##
============================================
+ Coverage     85.60%   87.67%   +2.07%     
- Complexity      336      341       +5     
============================================
  Files            22       23       +1     
  Lines           750      795      +45     
============================================
+ Hits            642      697      +55     
+ Misses          108       98      -10     
Impacted Files Coverage Δ Complexity Δ
...PHPDraft/Model/Elements/ObjectStructureElement.php 92.85% <0.00%> (-0.09%) 48.00 <0.00> (-1.00)
src/PHPDraft/Model/Resource.php 100.00% <ø> (+29.41%) 6.00 <0.00> (-1.00) ⬆️
src/PHPDraft/Parse/BaseHtmlGenerator.php 100.00% <ø> (ø) 1.00 <0.00> (ø)
src/PHPDraft/Out/TwigFactory.php 43.33% <43.33%> (ø) 4.00 <4.00> (?)
src/PHPDraft/Model/HTTPRequest.php 80.82% <63.63%> (-3.56%) 43.00 <1.00> (+3.00) ⬇️
src/PHPDraft/Model/HTTPResponse.php 91.11% <71.42%> (-3.89%) 23.00 <1.00> (+2.00) ⬇️
src/PHPDraft/Model/Transition.php 85.05% <90.90%> (-0.05%) 35.00 <0.00> (-1.00)
src/PHPDraft/Out/TemplateRenderer.php 99.05% <99.05%> (ø) 34.00 <34.00> (?)
.../PHPDraft/Model/Elements/BasicStructureElement.php 55.35% <100.00%> (ø) 23.00 <0.00> (ø)
src/PHPDraft/Model/HierarchyElement.php 100.00% <100.00%> (ø) 10.00 <0.00> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e0f53...d0b8cd1. Read the comment docs.

@SMillerDev SMillerDev force-pushed the twig branch 2 times, most recently from 5e9e057 to 1e2b2d3 Compare August 1, 2020 20:29
@SMillerDev SMillerDev force-pushed the twig branch 2 times, most recently from e15bb81 to c065adf Compare August 1, 2020 20:52
@SMillerDev SMillerDev merged commit d0b8cd1 into master Aug 1, 2020
@SMillerDev SMillerDev deleted the twig branch August 1, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants