Rework DexExpectStepKind StepKinds #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of these tests are failing at the moment. This will be addressed in another patch. Each new test has a summary explaining its purpose. Renamed directory expect_step_kinds -> expect_step_kind to match the command DexExpectStepKind.
This will make incoming future changes much easier to understand. Commands.md has been updated to explain what each StepKind means.
feature_tests/commands/perfect/expect_step_kind
/small_loop
The call to 'func' on line 20 returns to line 19. Dexter was treating
steps out of a function as a 'FUNC' StepKind (as well as the expected
step into a function). Becayse of this, the 'BACKWARD' step was being
hidden by a 'FUNC' StepKind.
Steps out of a function no longer count as 'FUNC'.
/recursive
This test was failing because the 'previous step' was in the same
function, and dexter assumed this meant no call had happened.
This has been fixed by checking if the call stack has grown between
steps instead.
NOTE: This test still fails. See the changes to Commands.md.
Rename: FORWARD -> VERTICAL_FORWARD BACKWARD -> VERTICAL_BACKWARD
This was referenced Sep 5, 2019
OCHyams
commented
Sep 5, 2019
|
NOTE: This should "Just work" with the |
TomWeaver18
suggested changes
Sep 17, 2019
TomWeaver18
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: I can separate this out into different pull requests if necessary.
Each commit has a message explaining what's going on. But, on a high level:
FUNC was counting steps OUT of functions.
Fixing FUNC showed many more than expected BACKWARD steps.
This is because BACKWARD/FORWARD was counting column movement as well as lines. This makes sense but is not very obvious from a test-writer/reader's perspective. See the example in Commands.md in commit 9dc209d "Fix DexExpectStepKind to match expected behaviour in feature_tests".
To reduce confusion, I've removed BACKWARD and FORWARD, and added:
VERTICAL_FORWARD: line++
VERTICAL_BACKWARD: line--
HORIZONTAL_FORWARD: column++
HORIZONTAL_BACKWARD: column--
I'm open renaming HORIZONTAL_* to COLUMN_* and VERTICAL_* to LINE_*, or anything else, if anyone feels strongly about this.