[Fishbones/phalanx] Update switchboard driver to fix kernel panic #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix kernel panic while removing switchboard_fpga.
tiantianlv
approved these changes
Feb 20, 2020
mudsut4ke
pushed a commit
that referenced
this pull request
Jan 25, 2021
a659219 [SONIC_SFP] adding abstract methods for reading and writing the eeprom address space within platform api (#126) 848f4a6 Add third-party licenses (#138) c2ecd9a Add license file (#137) 403747a [sonic-platform-common] Add new platform API for SONiC Physical MIB Extension feature (#134) 19b8545 [sonic_y_cable] fix the unpacking (#135) Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
mudsut4ke
pushed a commit
that referenced
this pull request
Jan 25, 2021
…it test issue (sonic-net#6247) e6c786b [xcvrd] Fix unit test issue with Python 3 (#135)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix kernel panic removing switcboard_fpga module while XCVR is accessing. While removing the module, invalid kernel object removal causes NULL pointer dependencies left in the kernel, and a function trying to access it causes kernel exception.
PLATFORMS: Phalanx, Fishbone32, and Fishbone48.
- How I did it
The NULL pointer condition check is added to i2c-access functions. If NULL is found, a function will not perform I2c operation and exit with ESHUTDOWN status indicates that the adapter is not ready to use (suspended).
Changes applied to followings functions:
- How to verify it
sfputil show eeprommodprobe -r switchboard_fpga.JIRA: CAFP-139
- Description for the changelog