added private assigment operator to Exception class to avoid MSVC warning #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning: C4512: 'SQLite::Exception' : assignment operator could not be generated ...'
|
Hi, sorry for not answering, I am not sure that this is the best fix for this warning... |
|
HI, subclasses of std::exception should have an assignment operator (I would actually expect that every class that has a copy constructor also to have an assignment operator). I've added such operator in PR #138, this should also fix the warning of Philipp2405 |
|
Thanks @fekir! As PR #138 is merge I can now close this. Sorry for the delay @Philipp2405 Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added private assigment operator to Exception class to avoid MSVC warning: C4512: 'SQLite::Exception' : assignment operator could not be generated ...' --> only created at warning level 4 !