Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add test for bz1913839 gid of filtered group still present #6280

Closed

Conversation

jakub-vavra-cz
Copy link
Contributor

Verifies
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1913839

Group id of a group that should have been filtered is visible in
the id command output.

Copy link
Contributor

@aplopez aplopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexey-tikhonov
Copy link
Member

alexey-tikhonov commented Mar 27, 2023

Patch for RHBZ 1913839 is in review upstream: #6613
Probably makes sense to align those two PRs.

@jakub-vavra-cz jakub-vavra-cz force-pushed the test-bz1913839-filter-group branch 3 times, most recently from 5a85707 to 233bc57 Compare April 24, 2023 11:11
@jakub-vavra-cz jakub-vavra-cz force-pushed the test-bz1913839-filter-group branch 2 times, most recently from f4e99b8 to 2ba25ef Compare April 27, 2023 14:02
@jakub-vavra-cz jakub-vavra-cz marked this pull request as ready for review April 27, 2023 14:03
Copy link
Contributor

@shridhargadekar shridhargadekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from doc-string correction, rest looks good.

src/tests/multihost/ad/test_adparameters_ported.py Outdated Show resolved Hide resolved
… in id

Verifies
    Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1913839

Group id of a group that should have been filtered is visible in
the id command output.

Fixed test numbering, removed un-needed backups,
moved log collection to later part of code to make the test_0016 more reliable.
@jakub-vavra-cz
Copy link
Contributor Author

Pushed PR: #6280

  • master
    • ed2510d - Tests: Add test for bz1913839 gid of filtered group gid still present in id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants