-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add test for bz1913839 gid of filtered group still present #6280
Closed
jakub-vavra-cz
wants to merge
1
commit into
SSSD:master
from
jakub-vavra-cz:test-bz1913839-filter-group
Closed
Tests: Add test for bz1913839 gid of filtered group still present #6280
jakub-vavra-cz
wants to merge
1
commit into
SSSD:master
from
jakub-vavra-cz:test-bz1913839-filter-group
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aplopez
reviewed
Jul 25, 2022
aplopez
approved these changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Patch for RHBZ 1913839 is in review upstream: #6613 |
jakub-vavra-cz
force-pushed
the
test-bz1913839-filter-group
branch
3 times, most recently
from
April 24, 2023 11:11
5a85707
to
233bc57
Compare
jakub-vavra-cz
force-pushed
the
test-bz1913839-filter-group
branch
2 times, most recently
from
April 27, 2023 14:02
f4e99b8
to
2ba25ef
Compare
shridhargadekar
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from doc-string correction, rest looks good.
… in id Verifies Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1913839 Group id of a group that should have been filtered is visible in the id command output. Fixed test numbering, removed un-needed backups, moved log collection to later part of code to make the test_0016 more reliable.
jakub-vavra-cz
force-pushed
the
test-bz1913839-filter-group
branch
from
April 28, 2023 08:25
2ba25ef
to
180258a
Compare
shridhargadekar
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verifies
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1913839
Group id of a group that should have been filtered is visible in
the id command output.