Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AD: Do not use the shortcut when filter_groups is set. #6613

Closed
wants to merge 1 commit into from

Conversation

aplopez
Copy link
Contributor

@aplopez aplopez commented Mar 8, 2023

When using id <user>, a shortcut avoids creating the proper group object but, instead, one where the SID is the group name is created. This prevents a proper filtering of groups which requires the actual group name.

Not using the shortcut will retrieve the group names and the filtering will work.

Resolves: #6617

@aplopez
Copy link
Contributor Author

aplopez commented Mar 8, 2023

Covscan is reporting a false positive on code not belonging to this PR. The variable is initialized in line 139.

When using 'id <user>', a shortcut avoids creating the proper group
object but, instead, one where the SID is the group name is created.
This prevents a proper filtering of groups which requires the actual
group name.

Not using the shortcut will retrieve the group names and the filtering
will work.

Resolves: SSSD#6617
@aplopez aplopez marked this pull request as ready for review March 9, 2023 10:37
@alexey-tikhonov alexey-tikhonov added the no-backport This should go to target branch only. label Mar 9, 2023
Copy link
Contributor

@thalman thalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the patch

@aplopez aplopez requested a review from sumit-bose March 22, 2023 08:29
Copy link
Contributor

@sumit-bose sumit-bose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

thanks for the patch, it is working for me, ACK.

bye,
Sumit

@alexey-tikhonov
Copy link
Member

Pushed PR: #6613

  • master
    • c3d6cc9 - AD: Do not use the shortcut when filter_groups is set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport This should go to target branch only. Pushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filter_groups doesn't filter GID from 'id' output: AD + 'ldap_id_mapping = True' corner case
4 participants