-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD: Do not use the shortcut when filter_groups is set. #6613
Conversation
Covscan is reporting a false positive on code not belonging to this PR. The variable is initialized in line 139. |
When using 'id <user>', a shortcut avoids creating the proper group object but, instead, one where the SID is the group name is created. This prevents a proper filtering of groups which requires the actual group name. Not using the shortcut will retrieve the group names and the filtering will work. Resolves: SSSD#6617
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
thanks for the patch, it is working for me, ACK.
bye,
Sumit
When using
id <user>
, a shortcut avoids creating the proper group object but, instead, one where the SID is the group name is created. This prevents a proper filtering of groups which requires the actual group name.Not using the shortcut will retrieve the group names and the filtering will work.
Resolves: #6617