Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XS✔ ◾ Rename the folders to match the rules URI #8472

Merged
merged 7 commits into from
Apr 30, 2024
Merged

Conversation

Aibono1225
Copy link
Member

@Aibono1225 Aibono1225 commented Apr 30, 2024

  1. What triggered this change? (PBI link, Email Subject, conversation + reason, etc)

✏️ Relates to SSWConsulting/SSW.Rules#1322

  1. What was changed?

✏️ Renamed some folders that have incorrect folder name

  1. Did you do pair or mob programming (list names)?

✏️ No

@github-actions github-actions bot added the Age: 🥚 - New About 2 hours old label Apr 30, 2024
Copy link
Contributor

Hi @Aibono1225,

Rule: ../../rules/do-you-assign-severity-levels/rule.md

Issues:

  • must have required property 'guid'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

PR Metrics

Thanks for keeping your pull request small.
Thanks for adding tests.

Lines
Product Code -
Test Code -
Subtotal -
Ignored Code 16
Total 16

Metrics computed by PR Metrics. Add it to your Azure DevOps and GitHub PRs!

@github-actions github-actions bot changed the title Rename the folders to match the rules URI XS✔ ◾ Rename the folders to match the rules URI Apr 30, 2024
Copy link
Contributor

Hi @Aibono1225,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/testing-pyramid/rule.md Line 27: list style Rule MD004
rules/testing-pyramid/rule.md Line 27 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: should be surrounded by blank lines Rule MD032
rules/testing-pyramid/rule.md Line 76: list style Rule MD004
rules/testing-pyramid/rule.md Line 76 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: should be surrounded by blank lines Rule MD032

Please review and update your Markdown files accordingly.

Copy link
Contributor

Hi @Aibono1225,

Rule: ../../rules/do-you-assign-severity-levels/rule.md

Issues:

  • must have required property 'guid'

Please fix the Frontmatter in your Markdown files.

Copy link
Contributor

Hi @Aibono1225,

We found some markdown suggestions for your Pull Request:

File Error Rule
rules/testing-pyramid/rule.md Line 27: list style Rule MD004
rules/testing-pyramid/rule.md Line 27 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: should be surrounded by blank lines Rule MD032
rules/testing-pyramid/rule.md Line 76: list style Rule MD004
rules/testing-pyramid/rule.md Line 76 MD032/blanks-around-lists Lists should be surrounded by blank lines [Context: should be surrounded by blank lines Rule MD032

Please review and update your Markdown files accordingly.

@Aibono1225 Aibono1225 closed this Apr 30, 2024
@Aibono1225 Aibono1225 reopened this Apr 30, 2024
@Aibono1225 Aibono1225 marked this pull request as draft April 30, 2024 07:22
@Aibono1225 Aibono1225 marked this pull request as ready for review April 30, 2024 07:42
Copy link
Member

@JackDevAU JackDevAU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff 🎉

@Aibono1225 Aibono1225 merged commit ed6a6b7 into main Apr 30, 2024
7 checks passed
@Aibono1225 Aibono1225 deleted the fix-folder-path branch April 30, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Age: 🥚 - New About 2 hours old
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants