Skip to content

innerHTML is used in places where DOMParser should be used #367

New issue
New issue
Open
Open
innerHTML is used in places where DOMParser should be used#367
Labels
type: bugSomething isn't working
@GarboMuffin

Description

@GarboMuffin
GarboMuffin
opened on Jan 22, 2023

Consider these functions:

ScratchTools/features/follower-count.js

Lines 11 to 12 in 471e718

var div = document.createElement("div");
div.innerHTML = data;

ScratchTools/features/hover-user-cards.js

Lines 34 to 35 in 471e718

var div2 = document.createElement("div");
div2.innerHTML = followersData;

ScratchTools/features/load-more-forum-posts.js

Lines 35 to 36 in 471e718

var div = document.createElement("div");
div.innerHTML = html.replaceAll("<!DOCTYPE html>", "");

It is my belief that these functions should use the DOMParser API instead of actual DOM elements

Metadata

Metadata

Assignees

No one assigned

    Labels

    type: bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions