Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Audit logs are not immutable #899

Open
flavio opened this issue May 25, 2016 · 3 comments
Open

Audit logs are not immutable #899

flavio opened this issue May 25, 2016 · 3 comments
Labels
2.4 bug

Comments

@flavio
Copy link
Member

flavio commented May 25, 2016

The audit logs can change over the time:

  1. user triggers webhook for namespace "foo"
  2. user downloads CSV audit file
  3. namespace "foo" is renamed "bar"
  4. user download CSV

The audit entry for event number 1 is reported in two different ways depending from the generation time. This is really wrong, the past events of the audit log should always stay the same!
@flavio flavio added the bug label May 25, 2016
@mssola mssola added this to the 2.2 milestone Oct 18, 2016
@holgerreif holgerreif mentioned this issue Oct 20, 2016
Closed
@AndreasUfert AndreasUfert mentioned this issue Oct 25, 2016
Closed
@mssola mssola mentioned this issue Jan 16, 2017
Closed
@mssola
Copy link
Collaborator

mssola commented Jan 19, 2017

I've hopefully fixed most of the issues with #1144, but I haven't completely reviewed this yet.

mssola added a commit to mssola/Portus that referenced this issue Jan 20, 2017
@mssola
Fixed some bugs related to activities
db553f8 
Besides the mentioned issues, this commit also fixes some activities when
deleting users. This commit also fixes most of the issues in SUSE#899, but
since this wasn't the goal of this commit, fixing this issue has been
left as something to be done in the near future (I'd still need to
properly review it).

Fixes SUSE#1104
Fixes SUSE#1106
See SUSE#899

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
mssola added a commit that referenced this issue Jan 20, 2017
@mssola
Fixed some bugs related to activities
2abfea9 
Besides the mentioned issues, this commit also fixes some activities when
deleting users. This commit also fixes most of the issues in #899, but
since this wasn't the goal of this commit, fixing this issue has been
left as something to be done in the near future (I'd still need to
properly review it).

Fixes #1104
Fixes #1106
See #899

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola mssola modified the milestones: Priorities for 2.2, Release 2.3 Aug 2, 2017
@mssola
Copy link
Collaborator

mssola commented Jan 18, 2018

This is probably fixed, but I'll continue to investigate during the 2.4 release.

@mssola mssola modified the milestones: Release 2.3, Release 2.4 Jan 18, 2018
@mssola
Copy link
Collaborator

mssola commented Jul 31, 2018

This is probably fixed, but I'll continue to investigate during the 2.4 release.

Same as before. I think it's fine, but we need more tests. Plus, I fear that #767 is going to bring some instability on this front. So, I prefer to postpone this to work harder on the tests.

@mssola mssola modified the milestones: Release 2.4, Release 2.5 Jul 31, 2018
@mssola mssola added the 2.4 label Jul 31, 2018
@mssola mssola removed this from the Release 2.5 milestone Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
2.4 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@flavio @mssola