Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

Implemented anonymous browsing #1377

Merged
merged 3 commits into from
Sep 7, 2017
Merged

Conversation

mssola
Copy link
Collaborator

@mssola mssola commented Aug 9, 2017

  • Configuration option (not everyone would like to enable this)
  • Improve the UI
  • Copy to clipboard pull command
  • Provide tests

Fixes #1129
Fixes #697
Fixes #1108

Signed-off-by: Miquel Sabaté Solà msabate@suse.com

@mssola
Copy link
Collaborator Author

mssola commented Aug 9, 2017

The UI right now is a disaster. @vitoravelino could you help me on this whenever you have some time ? 😇

asd

@vitoravelino
Copy link
Contributor

The UI right now is a disaster. @vitoravelino could you help me on this whenever you have some time ? 😇

Sure. 😄

@mssola
Copy link
Collaborator Author

mssola commented Aug 14, 2017

@vitoravelino some ideas on improving the UI:

  • Integrate better with the background. As in, I think it shouldn't be white on the background, since it's too shocking maybe ?
  • Clicking the tag should add the pull command to the user's clipboard (similar to Copying <repository URL>:<tag> to clipboard when tag name is clicked #697). This should be specified in a smaller font besides the "Search result" title (or a similar title that you want to have instead of that 😉)

@vitoravelino
Copy link
Contributor

Integrate better with the background. As in, I think it shouldn't be white on the background, since it's too shocking maybe ?

I'll see what I can do. Pray a little bit and let's hope I can come up with something reasonable. Haha.

Clicking the tag should add the pull command to the user's clipboard (similar to #697). This should be specified in a smaller font besides the "Search result" title (or a similar title that you want to have instead of that 😉)

Is this the only functionality on this page? Just a list of repositories without any interaction except for the copying to clipboard thing? Just want to be sure.

@mssola
Copy link
Collaborator Author

mssola commented Aug 14, 2017

Is this the only functionality on this page? Just a list of repositories without any interaction except for the copying to clipboard thing? Just want to be sure.

That's all I'm thinking right now. I mean, they are not logged-in, so they shouldn't have any more actions available, no ?

@vitoravelino
Copy link
Contributor

This is what I could come up with after some time...

screenshot 2017-08-22 20 31 35

@vitoravelino vitoravelino force-pushed the anonymous-browsing branch 2 times, most recently from 62002b7 to bad2185 Compare August 24, 2017 20:26
@mssola
Copy link
Collaborator Author

mssola commented Aug 30, 2017

This looks so much better! Thanks @vitoravelino !

One thing, when you visit this page for the first time (so no search has been performed), it shows "Your search did not match any repositories.", which is confusing. Other than that, it's perfect.

I'll proceed updating tests as soon as possible 😉

@mssola mssola changed the title [WIP] Implemented anonymous browsing Implemented anonymous browsing Sep 6, 2017
@mssola
Copy link
Collaborator Author

mssola commented Sep 6, 2017

@vitoravelino you can review this whenever you want. One test failed locally and I still need to check it locally (a crash on creating a namespace like in #1406)

@vitoravelino
Copy link
Contributor

Okie dokie!

This will allow (through a configurable option) anonymous users to
explore public images from the configured Docker registry.

Fixes SUSE#1129

Signed-off-by: Miquel Sabaté Solà <msabate@suse.com>
@mssola
Copy link
Collaborator Author

mssola commented Sep 6, 2017

@vitoravelino I was wrong, it finally passed 😇

@vitoravelino
Copy link
Contributor

One thing, when you visit this page for the first time (so no search has been performed), it shows "Your search did not match any repositories.", which is confusing. Other than that, it's perfect.

I've fixed this.

Copy link
Contributor

@vitoravelino vitoravelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mssola mssola merged commit 70188d5 into SUSE:master Sep 7, 2017
@mssola mssola deleted the anonymous-browsing branch September 7, 2017 07:52
@mssola
Copy link
Collaborator Author

mssola commented Sep 7, 2017

I've fixed this.

Thanks! 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants