Skip to content
This repository has been archived by the owner on Apr 17, 2023. It is now read-only.

config: improved garbage collector options #2095

Merged
merged 1 commit into from
Jan 16, 2019

Conversation

vitoravelino
Copy link
Contributor

@vitoravelino vitoravelino commented Jan 15, 2019

So far the garbage collector only had one simple option that was to
delete images older than X days.

In this patch we are introducing a new option and a new behavior. User
will now be able to keep the latest N images through keep_latest
option. And the images won't be deleted even if older than X days if
they were pulled in the latest X days.

Signed-off-by: Vítor Avelino vavelino@suse.com

mssola
mssola previously approved these changes Jan 16, 2019
Copy link
Collaborator

@mssola mssola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just fix the minor comments 😉

app/models/webhook.rb Outdated Show resolved Hide resolved
config/config.yml Outdated Show resolved Hide resolved
So far the garbage collector only had one simple option that was to
delete images older than X days.

In this patch we are introducing a new option and a new behavior. User
will now be able to keep the latest N images through `keep_latest`
option. And the images won't be deleted even if older than X days if
they were pulled in the latest X days.

Signed-off-by: Vítor Avelino <vavelino@suse.com>
@mssola mssola merged commit 02a2cac into SUSE:master Jan 16, 2019
@vitoravelino vitoravelino deleted the improve-garbage-collector branch February 4, 2019 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants