WIP - Caasp #52
Merged
WIP - Caasp #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhesketh
suggested changes
May 7, 2020
|
By the way, are you still configuring a loadbalancer somewhere? |
toabctl
suggested changes
May 12, 2020
As we discovered the lack of support in libcloud. However, at first I just disregarded the LB completely and use the masters directly. This is no long term solution. We need to discuss it. |
brunoleon
force-pushed
the
caasp
branch
9 times, most recently
from
7e82c82
to
bbef77c
Compare
toabctl
suggested changes
May 15, 2020
There was a problem hiding this comment.
- please log the original error message when you reraise an exception. Otherwise we lose information for debugging
- please don't rename files when not needed. This makes the whole review just more complicated so keep the
kubernetesdir for this and rename it in another commit if you think it's needed.
| @@ -24,6 +24,7 @@ class NodeBase(ABC): | |||
| """ | |||
| def __init__(self, name: str, private_key: str): | |||
| self.name = name | |||
| self.dnsname = self.name.replace('_', '-') | |||
There was a problem hiding this comment.
Still not resolved or answered
brunoleon
force-pushed
the
caasp
branch
4 times, most recently
from
2cdc545
to
531623d
Compare
toabctl
reviewed
May 15, 2020
brunoleon
force-pushed
the
caasp
branch
5 times, most recently
from
5ca0217
to
cf4ad37
Compare
Caasp deployment is making use of skuba deployment tool. This requires adding support for an ssh-agent Ideally would need a loadbalancer too but this is not implemented yet due to libcloud provider not supporting LB on openstack. Use "raw" (i.e yaml) ansible playbook. The code is written so that adding another distro support should be pretty easy. Renames kubernetes folder to k8s which is shorter and widely used
toabctl
approved these changes
May 17, 2020
Closed
|
Fixes #19 |
|
resolves #19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding CaaSP support