-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
saptune improvements for saptune version v2 #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…simulate - changes from 04.09.2017
handle different locations of the new configuration files (/usr/share/saptune/note, /etc/saptune/extra) expand section handling of the 'ini file' handler to handle the new configuration file entries sections: version, reminder, login, uuidd, mem, vm, block, limits, sysctl (new or changed) - changes from 04.09.2017
add parameter 'governor' to ini section 'cpu' support sysctl values with more than one field and operator unequal '=' support ini file entries with '', or blanks around the values adapt travis tests to the latest changes - changes from 08.09.2017
- changes from 08.09.2017
Additional actions needed in the pre-install script of the saptune package - changes from 07.11.2017
- changes from 07.11.2017
change handling and display of /dev/shm setting remove calculation of optimized values, only set the values from the config file irrespective of the current system value adapt solution definitions to the new SAP Note definitions
…d of static coding inside of saptune.
…vices/system/cpu/cpu* instead of /dev/cpu_dma_latency. Remove the parameter from the tuned.conf file and add it to the SAP note files '1984787' and '2205917' Remove action 'saptune note revert' and 'saptune solution revert'. Add action 'saptune revert all' instead Display footnotes during 'verify' and 'simulate' move setting of UserTaskMax into the postinstall of the package.
correct the revert of the vm.dirty parameters by additionally handling their counterpart parameters adjust customize to the new sap note config files and the new override location
…/saptune/extra adjust Netweaver solution definition support note definition files without version section rewrite man page saptune.8 and add new man page saptune-note.5
add different notes and solution definition for SLE15 remove Netweaver formular for page cache calculation. Use the HANA approach '2% system memory' for both preserve comment sections of the security limits file /etc/security/limits.conf esp. if this is the only content of the file. add additional test cases
…versions. (bsc#1120741) change 'if var1 == string1 || var1 == string2 || ...' to 'switch' to support the newer go compiler version
adjust comment concerning page cache calculation to make clear, that the HANA ormula is now used for Netweaver too adjust some unit tests to support power architecture.
…>' again. add parameter based saved state files to support proper revert functionality change company name in copyright lines
support solution names with '+' prevent parameter storing during a pure 'note verify' disable parameter settings using an override file store the order of the note as they are applied to get the same system tuning result after a system reboot as before make sure a note, which is part of an applied solution definition, but was reverted manually later, will NOT applied again after a system reboot.
… of a ini file 'key value' pair
…rt) to the special needs of the security limits parameter (bsc#1124485)
add support for test coverage using codeclimate on branch 'master' of repository SUSE/saptune
add new SAP Notes to the solution definition add bash-completion for saptune
…Action) to suppress misleading messages for the customer and adjust the tests
We now ship combined solutions e.g. HANA and Netweaver by default so there is no need for the customer to apply more than one solution. And we can easily change or enhance the solution definition by a maintenance package of saptune or by a support advice directly to the customer as 'solution override' is working, but NOT public available/described by intention.
…able these services (bsc#1128325) use 'tuned-adm profile' and 'tuned-adm active' commands instead of writing/reading file /etc/tuned/active_profile directly
work as dual version binary by checking SAPTUNE_VERSION string in the configuration and execute the 'old' version 1 saptune binary, if needed. add checks to find and log left over files from the v1 to v2 migration or probably wrong and dangerous version 1 configurations remove the compatibility functions from saptune version 2 as they are no lonnger needed remove the 'SUSE-GUIDE-*' notes from saptune version 2 as they produce more trouble than help add man page saptune_v1.8, saptune_v2.8 and saptune-migration.5
…une/extra. Old file names still valid and supported for compatibility reasons. Add header support (version, date, description) for the vendor files available in /etc/saptune/extra as already available for the note definition files in /usr/share/saptune/notes
…use a dedicated branch for this version
add description for saptune actions 'version' and 'help' to the man page saptune_v2
…5 2578899 remove SAP Note 1805750 from the solution defintion. The Note needs customization to be applyable. So it makes no sense to have this Note in a solution definition.
…Note and NO longer during postinstall of package installation (bsc#1124489)
…ne package to the upd_helper script to simplify the package scripts ignore saved state files with suffix '_n2c' during RevertAll action as they are only migration helper files and no active saved state files
using different LogWriters for INFO, WARNING, ERROR and DEBUG add the expected format (<date> <timestamp> <prio:8> saptune.<saptune_routine>:<line_no> <message>)
diegoakechi
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge of the changes from branch saptune_improvements
Details see the commit messages