-
-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handicap games need special gtp commands #409
Comments
Thanks, that was fast ! |
Hmm... Did you check the GTP console to see if Sabaki was sending the right commands? |
Yes, looking at pachi's log actually. This is the commands i'm seeing for an 8-stones game:
|
How did you create the game? When I create an 8-stone handicap game in Sabaki and attach an engine, Sabaki sends the following commands:
|
Something weird going on then, i did: |
Works for me (albeit I don't have Pachi to try it with). |
Wait, do i have to npm update or something to pick up the changes ? |
Yeah I think you'll need |
Ok, working now, yay. |
For future reference, the README refers to the documentation in section 'Building & Testing'. You can find a list of available npm run commands there. Basically, it suffices to run:
That said, |
|
Uh, I upgraded Electron and now |
Arg! The upgrade hadn't taken me to Electron 2. Having fixed that, now it works properly. |
This issue was fixed in version 0.35, but I just upgraded to version 0.40 and the issue seems to be back. Can anyone confirm? |
|
Thank you. |
Actually - the behaviour seems to differ based on how play is started. With preference "start game right after attaching" OFF, the But with that preference set to ON, the |
@fohristiwhirl Unfortunately, I can't reproduce this behavior. Can you write down the steps that led to it? But funnily enough, I stumbled upon another bug: If there are handicap stones, engine synchronization is always starting from an empty board. |
Ok, I was able to reproduce it on v0.40.1, but it has already been fixed on master branch. |
Thanks. I can reproduce this exact behavior.
So the issue is still closed. :) |
Hi,
Following up on pasky/pachi#82, it seems sabaki is sending handicap stones as
play b
commands instead of using dedicated gtp commands, so engines are mislead into thinking it's an even game. Pachi resigns high handicap games when playing through sabaki right now because of this.For chinese rules
set_free_handicap
/place_free_handicap
command should be used to send/get handicap stones. Or justfixed_handicap
with japanese rules.gtp2ogs had the same issue some time ago, could check online-go/gtp2ogs#65 for details.
The text was updated successfully, but these errors were encountered: