Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Nov 5, 2022

Closes #1108.

Summary of Changes

Created a migrate cli command, that takes two api files, an annotation file, and an output path as input

Testing Instructions

Run Terminal with parse-package migrate -a1 apiv1.json -a2 apiv2.json -a annotations.json -o out

@Aclrian Aclrian linked an issue Nov 5, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON prettier 1 0 0 1.26s
⚠️ MARKDOWN markdownlint 1 0 1 1.03s
✅ MARKDOWN markdown-link-check 1 0 0.56s
✅ PYTHON bandit 2 0 0.65s
✅ PYTHON black 2 0 0 1.38s
✅ PYTHON flake8 2 0 0.49s
✅ PYTHON isort 2 0 0 0.88s
✅ PYTHON mypy 2 0 3.84s
✅ PYTHON pylint 2 0 3.05s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian Aclrian marked this pull request as ready for review November 5, 2022 13:48
@Aclrian Aclrian requested a review from lars-reimann as a code owner November 5, 2022 13:48
@Aclrian
Copy link
Contributor Author

Aclrian commented Nov 5, 2022

Still needs smoke tests. Is the naming of the arguments ok? Another '-a' exists in the annotations command, which is for the api.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change required.

@lars-reimann lars-reimann merged commit 08f5440 into main Nov 9, 2022
@lars-reimann lars-reimann deleted the 1108-create-command-line-interface-for-a-migrate-command branch November 9, 2022 08:31
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

🎉 This PR is included in version 1.65.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create command line interface for a migrate command

2 participants