This repository was archived by the owner on Jan 19, 2025. It is now read-only.
feat: migrate @rename annotations
#1123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
switching to an other pc - migth not working <3 to xorg
and unspecified-encoding
from classes, and (global) functions
with included license
and hopefully the error disapperears
…iffer # Conflicts: # package-parser/package_parser/processing/migration/_differ.py
… 1118-map-list-of-old-api-elements-to-list-of-new-api-elements
…-rename-annotations
…ements' into 1120-migrate-rename-annotations
…-new-api-elements # Conflicts: # package-parser/package_parser/processing/migration/__init__.py
Aclrian
force-pushed
the
1120-migrate-rename-annotations
branch
2 times, most recently
from
0169073 to
d52094c
Compare
like API, AnnotationStore
Aclrian
force-pushed
the
1120-migrate-rename-annotations
branch
from
8039e02 to
e235631
Compare
…ements' into 1120-migrate-rename-annotations # Conflicts: # package-parser/package_parser/processing/migration/__init__.py
|
If you're done with a feature, feel free to merge it in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1120.
Summary of Changes
The migrate command for rename annotation is now working:
If an annotation is mapped via an
One/ManyToOneMapping, a new remove annotation would be created for this one apiv2 element.Otherwise, there are two options:
@removeannotation would be created for this element.@todoannotation.Testing Instructions
run the migrate command or view and run the test_migration.py file