Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

feat: migrate @todo annotations #1141

Merged
merged 15 commits into from
Dec 5, 2022
Merged

feat: migrate @todo annotations #1141

merged 15 commits into from
Dec 5, 2022

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Dec 3, 2022 •
edited
Loading

Closes #1124.

Summary of Changes

  • add migration for todo annotations to another version, with the possibilities:
    • If the annotation is mapped to only one api element, the annotation will be migrated as expected.
    • If the annotation is mapped to multiple api elements, a todo annotation will be created for each api elements in the image for the mapping. If the type of the annotated of api element from apiv1 and the type of the to be annotated apiv2 element does not match, a unsure todo annotation will be created concerning this.

Testing Instructions

run the migrate command or view and run the test_migration.py file

@Aclrian Aclrian linked an issue Dec 3, 2022 that may be closed by this pull request
Migrate @todo annotations #1124
Closed
@Aclrian Aclrian changed the title featmigrate todo annotations feat:migrate todo annotations Dec 3, 2022
@Aclrian Aclrian changed the title feat:migrate todo annotations feat: migrate todo annotations Dec 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022 •
edited
Loading

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 8 0 0.67s
✅ PYTHON black 8 0 0 1.74s
✅ PYTHON flake8 8 0 0.49s
✅ PYTHON isort 8 0 0 1.15s
✅ PYTHON mypy 8 0 3.32s
✅ PYTHON pylint 8 0 2.92s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian Aclrian force-pushed the 1124-migrate-todo-annotations branch from 8b74351 to fe7d221 Compare December 3, 2022 17:27
@Aclrian Aclrian closed this Dec 3, 2022
@Aclrian Aclrian force-pushed the 1124-migrate-todo-annotations branch from fe7d221 to b2cf4bc Compare December 3, 2022 18:43
@Aclrian Aclrian reopened this Dec 3, 2022
@Aclrian Aclrian changed the title feat: migrate todo annotations feat: migrate @todo annotations Dec 4, 2022
Aclrian and others added 7 commits December 4, 2022 20:48
@Aclrian
fix linter error
de0883f
@Aclrian
add tests and adjust migration
7dbc40b
@Aclrian
fix linter errors
c205957
@Aclrian @github-actions
style: apply automated linter fixes
618ea8e
@Aclrian
Merge remote-tracking branch 'origin/main' into 1124-migrate-todo-ann…
4a8768a 
…otations

# Conflicts:
#	package-parser/package_parser/processing/migration/_migrate.py
#	package-parser/tests/processing/migration/annotations/test_rename_migration.py
#	package-parser/tests/processing/migration/test_migration.py
@Aclrian @github-actions
style: apply automated linter fixes
5c992e2
@Aclrian
inspect type of annotated element
27bc4d9
@Aclrian Aclrian force-pushed the 1124-migrate-todo-annotations branch from 18d0c7c to 27bc4d9 Compare December 5, 2022 17:47
@Aclrian Aclrian force-pushed the 1124-migrate-todo-annotations branch from 0300634 to feab4e1 Compare December 5, 2022 18:19
@Aclrian Aclrian marked this pull request as ready for review December 5, 2022 18:32
@Aclrian Aclrian requested a review from lars-reimann as a code owner December 5, 2022 18:32
@Aclrian Aclrian removed the request for review from lars-reimann December 5, 2022 18:32
@Aclrian Aclrian merged commit a9684ea into main Dec 5, 2022
@Aclrian Aclrian deleted the 1124-migrate-todo-annotations branch December 5, 2022 19:03
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

🎉 This PR is included in version 1.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
released Included in a release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate @todo annotations
1 participant
@Aclrian