Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Dec 14, 2022

Closes #1144.

Summary of Changes

  • Migration of @remove annotations through a mapping from old api elements to new api elements.
    If the mapped apiv2 element is removable (a class or function), change the target of the annotation.
    Otherwise, mark the api element that are not removable with an @todo annotation.
  • New methods get_annotated_api_element and get_annotated_api_element_by_type to get the element from an annotation by its id.

Testing Instructions

run the migrate command or view and run the test_migration.py file

@Aclrian Aclrian linked an issue Dec 14, 2022 that may be closed by this pull request
@Aclrian Aclrian changed the title add @remove migration feat: add @remove migration Dec 14, 2022
@github-actions
Copy link

github-actions bot commented Dec 14, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 9 0 0.82s
✅ PYTHON black 9 0 0 1.91s
✅ PYTHON flake8 9 0 0.64s
✅ PYTHON isort 9 0 0 1.19s
✅ PYTHON mypy 9 0 4.36s
✅ PYTHON pylint 9 0 4.09s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian Aclrian marked this pull request as ready for review December 15, 2022 15:33
@Aclrian Aclrian removed the request for review from lars-reimann December 15, 2022 15:33
@Aclrian Aclrian merged commit 36026ea into main Dec 15, 2022
@Aclrian Aclrian deleted the 1144-migrate-remove-annotations branch December 15, 2022 15:35
@github-actions
Copy link

🎉 This PR is included in version 1.79.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate @remove annotations

1 participant