Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Dec 16, 2022

Closes #1150.

Summary of Changes

  • Migration of @CalledAfter annotations through a mapping from old api elements to new api elements for the two function called before or after.
    If there is no mapping from the function called before to another function in the class of the apiv2 element, an unsure @CalledAfter annotation will be created with the same name as the function called before.
    Else, a @CalledAfter annotation will be created, if the called before function is mapped to only one other function and the annotated apiv2 element is a function.
    Otherwise, mark the mapped apiv2 elements with a @todo annotation.

Testing Instructions

run the migrate command or view and run the test_migration.py file

@Aclrian Aclrian linked an issue Dec 16, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Dec 16, 2022

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 9 0 0.66s
✅ PYTHON black 9 0 0 1.54s
✅ PYTHON flake8 9 0 0.52s
✅ PYTHON isort 9 0 0 0.91s
✅ PYTHON mypy 9 0 3.1s
✅ PYTHON pylint 9 0 2.9s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian Aclrian marked this pull request as ready for review December 17, 2022 15:29
@Aclrian Aclrian removed the request for review from lars-reimann December 17, 2022 15:30
@Aclrian Aclrian merged commit 8ad8e6a into main Dec 17, 2022
@Aclrian Aclrian deleted the 1150-migrate-calledafter-annotations branch December 17, 2022 15:40
@github-actions
Copy link

🎉 This PR is included in version 1.80.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate @CalledAfter annotations

1 participant