Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Jan 3, 2023

Closes ##1179.

Summary of Changes

add dependecy levenshtein and use its distance function in name_similarity

Testing Instructions

run package-parser/tests/processing/migration/test_differ.py in the main branch and in this branch and compare the running time

@Aclrian Aclrian linked an issue Jan 3, 2023 that may be closed by this pull request
@Aclrian Aclrian changed the title Improve calculating of Levenshtein Distance feat: Improve calculating of Levenshtein Distance Jan 3, 2023
@Aclrian
Copy link
Contributor Author

Aclrian commented Jan 3, 2023

Running time on my computer with running background processes:
before = [12.04, 12.26, 12.34, 12.22, 12.41]
after = [1.65, 1.53, 1.60, 1.59, 1.59]

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 0.6s
✅ PYTHON black 2 0 0 1.48s
✅ PYTHON flake8 2 0 0.42s
✅ PYTHON isort 2 0 0 0.99s
✅ PYTHON mypy 2 0 3.07s
✅ PYTHON pylint 2 0 2.49s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian
Copy link
Contributor Author

Aclrian commented Jan 3, 2023

@Aclrian Aclrian marked this pull request as ready for review January 3, 2023 14:41
@Aclrian Aclrian requested a review from lars-reimann as a code owner January 3, 2023 14:41
@Aclrian Aclrian merged commit ab94562 into main Jan 3, 2023
@Aclrian Aclrian deleted the 1179-calculating-levenshtein-distance-for-strings-takes-a-long-time branch January 3, 2023 14:43
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

🎉 This PR is included in version 1.84.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calculating Levenshtein Distance for strings takes a long time

1 participant