Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

Aclrian
Copy link
Contributor

@Aclrian Aclrian commented Jan 17, 2023

Closes #1188.

Summary of Changes

If the type of an attribute is unknown, they will be added to the API as well.

Testing Instructions

run the api command with a class that has an attribute with no type hints.

@Aclrian Aclrian linked an issue Jan 17, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 17, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ JSON eslint-plugin-jsonc 2 0 0 20.16s
✅ JSON jsonlint 2 0 0.81s
✅ JSON prettier 2 0 0 13.63s
✅ JSON v8r 2 0 1.78s
✅ PYTHON bandit 3 0 0.59s
✅ PYTHON black 3 0 0 1.55s
✅ PYTHON flake8 3 0 0.55s
✅ PYTHON isort 3 0 0 1.36s
✅ PYTHON mypy 3 0 2.25s
✅ PYTHON pylint 3 0 5.76s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@Aclrian Aclrian force-pushed the quickfix-for-creation-of-instance-attributes branch 5 times, most recently from 9519e5e to 06f2694 Compare January 17, 2023 16:57
@Aclrian Aclrian force-pushed the quickfix-for-creation-of-instance-attributes branch from 06f2694 to f902c96 Compare January 17, 2023 17:00
@Aclrian Aclrian changed the title fix: Generate Attributes even their type is unknown fix: generate Attributes even their type is unknown Jan 17, 2023
@Aclrian Aclrian changed the title fix: generate Attributes even their type is unknown fix: generate attributes even their type is unknown Jan 17, 2023
@Aclrian Aclrian marked this pull request as ready for review January 17, 2023 17:09
@Aclrian Aclrian requested a review from lars-reimann as a code owner January 17, 2023 17:09
@Aclrian Aclrian merged commit 719d0ca into main Jan 17, 2023
@Aclrian Aclrian deleted the quickfix-for-creation-of-instance-attributes branch January 17, 2023 17:10
@github-actions
Copy link

🎉 This PR is included in version 1.86.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some attributes will not be generated

1 participant