Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 28, 2021

Closes #309.

Summary of Changes

  • Fix incorrect handling of properties
  • Add @getter, @setter, or @deleter to the names of the corresponding functions to uniquely identify them

Screenshots (if necessary)

image

Testing instructions

  1. Import the new scikit-learn data.
  2. Check that the power property now works properly. This is the only property we have in the data.

@github-actions
Copy link

github-actions bot commented Nov 28, 2021

Mega-Linter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 2.35s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 1 0 0 9.12s
✅ JSON jsonlint 1 0 3.11s
✅ JSON prettier 1 0 0 9.92s
✅ JSON v8r 1 0 1.89s
✅ TSX eslint 1 0 0 10.94s
✅ TYPESCRIPT eslint 8 0 0 10.53s
✅ TYPESCRIPT prettier 9 0 0 2.27s

See errors details in artifact Mega-Linter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paul0314 paul0314 merged commit 8d9a910 into main Nov 28, 2021
@paul0314 paul0314 deleted the feature/unique_name branch November 28, 2021 18:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Duplicate functions lead to malfunctioning of treeview

2 participants