Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jan 10, 2022

Closes #386.
Closes #388.

Summary of Changes

  • Replace strings in model with richer types
  • Overhaul generation of Python code
  • Add units tests
  • Also include minor changes to the validator, which are not worth putting into a separate PR

Testing instructions

  • Test generation of Python code for various inputs

@lars-reimann lars-reimann requested a review from paul0314 January 10, 2022 20:17
@github-actions
Copy link

github-actions bot commented Jan 10, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.8s
✅ GIT git_diff yes no 0.01s
✅ KOTLIN ktlint 25 0 0 62.39s

See errors details in artifact MegaLinter reports on GitHub Action page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

Copy link
Contributor

@paul0314 paul0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@paul0314 paul0314 merged commit 36680e2 into main Jan 13, 2022
@paul0314 paul0314 deleted the fix/pyCodegen branch January 13, 2022 16:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forbid combinations enum+attribute and enum+optional Various issues with Python codegen
2 participants