Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jun 24, 2022

Closes #760.
Closes #744.

Summary of Changes

Regarding the generation of @enum annotations:

  • Allow numbers in names of generated enum instances
  • Prepend an _ if the name would start with a number
  • Replace - with _ instead of dropping it outright
  • Use UPPER_CASE for names of enum instances

@github-actions
Copy link

github-actions bot commented Jun 24, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.45s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 3 0 0 2.9s
✅ JSON jsonlint 3 0 1.21s
✅ JSON prettier 3 0 0 1.94s
✅ JSON v8r 3 0 2.66s
✅ PYTHON bandit 1 0 0.26s
✅ PYTHON black 1 0 0 0.33s
✅ PYTHON flake8 1 0 0.36s
✅ PYTHON isort 1 0 0 0.14s
✅ PYTHON mypy 1 0 5.5s
✅ PYTHON pylint 1 0 1.86s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann merged commit 9c03ff0 into main Jun 24, 2022
@lars-reimann lars-reimann deleted the 760-same-enum-instance-names-if-the-string-values-only-difference-are-numbers branch June 24, 2022 19:13
@github-actions
Copy link

🎉 This PR is included in version 1.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jun 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Same enum instance names if the string values only difference are numbers Enums should be uppercase according to pep8

1 participant