Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jul 1, 2022

Closes #858.

Summary of Changes

For string values like "SAMME.R" we now create the enum instance name "SAMME_R" rather than "SAMMER".

@lars-reimann lars-reimann linked an issue Jul 1, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 4.43s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 2 0 0 1.27s
✅ JSON jsonlint 2 0 0.54s
✅ JSON prettier 2 0 0 0.61s
✅ JSON v8r 2 0 1.93s
✅ PYTHON bandit 1 0 0.32s
✅ PYTHON black 1 0 0 0.34s
✅ PYTHON flake8 1 0 0.42s
✅ PYTHON isort 1 0 0 0.17s
✅ PYTHON mypy 1 0 10.05s
✅ PYTHON pylint 1 0 2.09s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann merged commit 8a401d4 into main Jul 1, 2022
@lars-reimann lars-reimann deleted the 858-dots-in-enum-strings-should-get-converted-to-underlines branch July 1, 2022 12:46
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

🎉 This PR is included in version 1.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dots in enum strings should get converted to underlines

1 participant