Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Jul 2, 2022

Closes #874.

Summary of Changes

  • New annotation @value that subsumes @attribute, @constant, @optional, and @required
  • Migration script for old annotation data to new schema
  • @attribute annotations are no longer available since they were very specific to sklearn. The migration script replaces them with @optional annotations with the same default value.

Screenshots (if necessary)

image


image


image

@lars-reimann lars-reimann marked this pull request as draft July 2, 2022 18:45
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.71s
✅ GIT git_diff yes no 0.01s
✅ JSON eslint-plugin-jsonc 13 0 0 3.2s
✅ JSON jsonlint 13 0 3.81s
✅ JSON prettier 13 0 0 2.61s
✅ JSON v8r 13 0 7.16s
✅ KOTLIN ktlint 49 0 0 113.28s
✅ PYTHON bandit 10 0 0.36s
✅ PYTHON black 10 0 0 0.49s
✅ PYTHON flake8 10 0 0.51s
✅ PYTHON isort 10 0 0 0.15s
✅ PYTHON mypy 10 0 51.59s
✅ PYTHON pylint 10 0 3.11s
✅ TSX eslint 24 0 0 14.17s
✅ TYPESCRIPT eslint 31 0 0 12.15s
✅ TYPESCRIPT prettier 55 0 0 6.3s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann changed the title feat!: @value annotation to replace @attribute, @constant, @optional, @required feat: @value annotation to replace @attribute, @constant, @optional, @required Jul 2, 2022
@lars-reimann lars-reimann marked this pull request as ready for review July 2, 2022 22:39
@lars-reimann lars-reimann merged commit cf83477 into main Jul 2, 2022
@lars-reimann lars-reimann deleted the 874-replace-attribute-constant-optional-required-by-one-value-annotation branch July 2, 2022 22:39
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

🎉 This PR is included in version 1.38.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace @attribute, @constant, @optional, @required by one @value annotation

1 participant