This repository was archived by the owner on Jan 19, 2025. It is now read-only.
feat(gui): show default value from code and documentation in selection view #947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion will be showed, now.
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
…-selection-view-of-parameters
lars-reimann
changed the title
lars-reimann
suggested changes
Jul 8, 2022
There was a problem hiding this comment.
The current solution does not work well if the fields are empty:
If the code field is empty, the message "The parameter is required." should be shown and both fields omitted:
If the documentation field is empty, the message "The documentation does not specify a default value." should be shown.
Both should be formatted like the text about missing documentation:
…mentation-in-selection-view-of-parameters' into 902-show-default-value-from-documentation-in-selection-view-of-parameters # Conflicts: # api-editor/gui/src/features/packageData/selectionView/ParameterView.tsx
|
Changes were applied. |
lars-reimann
approved these changes
Jul 8, 2022
lars-reimann
deleted the
902-show-default-value-from-documentation-in-selection-view-of-parameters
branch
|
🎉 This PR is included in version 1.52.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #902
Summary of Changes
See Issue.
Screenshots (if necessary)
JSON File of API - data:
Result in API-Eidtor:
Testing Instructions