Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

GideonKoenig
Copy link
Contributor

Closes #903.

Summary of Changes

Links to Methods are now being properly displayed as actual links instead of :meth:.

Testing Instructions

Open api-editor with api and usage data for sklearn.
Open #/sklearn/sklearn.decomposition._pca/PCA and click on the link in the description (for class test).
Open #/sklearn/sklearn.preprocessing._encoders/OneHotEncoder/init/handle_unknown (for method test).

@GideonKoenig GideonKoenig linked an issue Jul 8, 2022 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 4.48s
✅ GIT git_diff yes no 0.01s
✅ TSX eslint 1 0 0 9.71s
✅ TYPESCRIPT prettier 1 0 0 1.67s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@GideonKoenig GideonKoenig changed the title feat: meth lab is done, walter sends his regard feat: implements links to methods in element description Jul 8, 2022
@GideonKoenig GideonKoenig requested a review from lars-reimann July 8, 2022 12:43
@lars-reimann lars-reimann changed the title feat: implements links to methods in element description feat(gui): implements links to methods in element description Jul 8, 2022
Copy link
Contributor

@nvollroth nvollroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nvollroth nvollroth merged commit faa656f into main Jul 8, 2022
@nvollroth nvollroth deleted the 903-replace-methab-with-link-to-method-ab branch July 8, 2022 13:25
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🎉 This PR is included in version 1.51.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace :meth:ab with link to method ab

3 participants