Skip to content
This repository was archived by the owner on Jan 19, 2025. It is now read-only.

Conversation

GideonKoenig
Copy link
Contributor

Closes #934.

Summary of Changes

Added a addUnusedParamerts function to the constructor of the UsageCountStore, since parameters with 0 usages were missing.

Testing Instructions

Open api-editor with api and usage data for sklearn.
Open any of the following examples:

Parameters with prior missing statistics:
sklearn.ensemble.VotingRegressor.fit.sample_weight (Default Value: None)
sklearn.ensemble.StackingRegressor.fit.sample_weight (Default Value: None)
sklearn.ensemble.IsolationForest.init.warm_start (Default Value: False)
sklearn.ensemble.IsolationForest.fit.sample_weight (Default Value: None)
sklearn.ensemble.HistGradientBoostingRegressor.init.warm_start (Default Value: False)

Parameters with prior working statistics:
sklearn.ensemble.StackingRegressor.init.passthrough (Default Value: False)
sklearn.ensemble.HistGradientBoostingClassifier.init.warm_start (Default Value: False)
sklearn.ensemble.HistGradientBoostingClassifier.init.tol (Default Value: 1e-07)

@GideonKoenig GideonKoenig linked an issue Jul 8, 2022 that may be closed by this pull request
@GideonKoenig GideonKoenig requested a review from lars-reimann July 8, 2022 13:52
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ CREDENTIALS secretlint yes no 3.85s
✅ GIT git_diff yes no 0.01s
✅ TYPESCRIPT eslint 1 0 0 7.31s
✅ TYPESCRIPT prettier 1 0 0 1.16s

See errors details in artifact MegaLinter reports on CI Job page
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

@lars-reimann lars-reimann changed the title feat: resolve bug of missing parameter statistics fix(gui): resolve bug of missing parameter statistics Jul 8, 2022
@lars-reimann lars-reimann merged commit 4d02e27 into main Jul 8, 2022
@lars-reimann lars-reimann deleted the 934-missing-usage-statistic branch July 8, 2022 18:24
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🎉 This PR is included in version 1.55.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Included in a release label Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Usage Statistic
2 participants