-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget updates #103
Widget updates #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @jwildfire ! a couple of minor comments
-
hepExplorer
nR
andPalt
work well! I like having the Palt reference!- suggest adding reference to R and nR ratio somewhere (ideally in the widget), e.g.
baseline
andanalysis
mapping inhepExplorer()
do not match hepexplorer.js parameterization
Lines 53 to 56 in 4652165
baseline_flag_col = "", baseline_flag_values = "", analysis_flag_col = "", analysis_flag_values = "",
expecting baseline as a list
safetyCharts/inst/htmlwidgets/lib/hep-explorer-1.4.2/hepexplorer.js
Lines 255 to 258 in 4652165
baseline: { value_col: null, //synced with studyday_col in syncsettings() values: [0] },
mDish is working with the following code.
# enable mDish plot example mapping_baseline <- list( measure_col = "PARAM", measure_values = list( ALT = "Alanine Aminotransferase (U/L)", AST = "Aspartate Aminotransferase (U/L)", TB = "Bilirubin (umol/L)", ALP = "Alkaline Phosphatase (U/L)" ), ## mDish does not work with this mapping # baseline_flag_col = "ABLFL", # baseline_flag_values = "Y", ## mDish works with a baseline list, baseline = list( value_col = "ABLFL", values = "Y" ), analysis_flag_col = "", analysis_flag_values = "", id_col = "USUBJID", value_col = "AVAL", normal_col_low = "A1LO", normal_col_high = "A1HI", studyday_col = "ADY", visit_col = "VISIT", visitn_col = "VISITNUM", unit_col = "" ) hepExplorer(df = safetyData::adam_adlbc, mapping = mapping_baseline)
-
aeTimelines. Looks great! Only comment is the
ASTDY
has huge negative values insafetyData::adam_adae
. Perhaps can filter out in vignette for better viewing experience.# Extra color added when new category added. Not 100% ideal, but ok. customSevSer <- safetyData::adam_adae %>% filter(ASTDY > -50) %>% # add a filter to make the timeline more viewable rename(sev = AESEV) %>% rename(ser = AESER) %>% mutate(sev = if_else(sev == "MILD", "WILD!", sev)) safetyGraphicsApp( domainData = list(aes = customSevSer), mapping = list(aes = list(severity_col = "sev", serious_col = "ser")) )
Good idea - filed SafetyGraphics/hep-explorer#335 |
I updated the docs a bit in #104 on Friday and cleaned this up. FWIW, the default mapping was pasted from the safetyGraphicsApp() export which includes |
Actually going to just delete those options. See #105. |
Yeah, I've been meaning to do this in the hosted example. Added a comment here as a reminder. |
Overview
This should wrap up the updates for v0.3! Once this is merged I'll work on getting this to CRAN and then try to finalize safetyGraphics v2.1.
Test Notes