Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated metaviper/gsea enrichment #92

Merged
merged 8 commits into from
Dec 17, 2019
Merged

Updated metaviper/gsea enrichment #92

merged 8 commits into from
Dec 17, 2019

Conversation

allaway
Copy link
Collaborator

@allaway allaway commented Dec 15, 2019

By drug, this time. This is more interesting than the previous one, but based on the network plots it's pretty clear that this analysis effectively disregards any drugs with only a few listed targets. I included all drugs, though, but pretty much all of the highest-enriched drugs are have a broad range of protein targets

Copy link
Contributor

@sgosline sgosline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change is to move to results directory. Pretty exciting stuff!

30-viper-drug-enrichment-bydrug.Rmd Outdated Show resolved Hide resolved
@allaway
Copy link
Collaborator Author

allaway commented Dec 15, 2019

Whoops, didn't realize it was in the wrong directory. just fixed that!

@sgosline sgosline self-requested a review December 16, 2019 03:51
Copy link
Contributor

@sgosline sgosline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, that was my only concern. simpler is better :)

@sgosline
Copy link
Contributor

Re-cap of offline conversation: I think it'd be helpful to include bargraph of number of targets for each drug alongside the enrichment plots

Additional question - is the foldchange in the network actually correlation? If so this is interesting.

@allaway
Copy link
Collaborator Author

allaway commented Dec 16, 2019 via email

@allaway
Copy link
Collaborator Author

allaway commented Dec 17, 2019

Re-cap of offline conversation: I think it'd be helpful to include bargraph of number of targets for each drug alongside the enrichment plots

Additional question - is the foldchange in the network actually correlation? If so this is interesting.

@sgosline barplots are added in the latest version of this branch!

Copy link
Contributor

@sgosline sgosline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for the updates!

@allaway allaway merged commit 3c7f480 into master Dec 17, 2019
@allaway allaway deleted the vipergsea branch December 17, 2019 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants