Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(help): add playwright tests #6317

Merged
merged 1 commit into from
Sep 26, 2023
Merged

test(help): add playwright tests #6317

merged 1 commit into from
Sep 26, 2023

Conversation

divyajindel
Copy link
Contributor

@divyajindel divyajindel commented Sep 14, 2023 •
edited by sianford
Loading

Proposed behaviour

  • Refactor cypress tests to playwright

Current behaviour

  • Tests are currently using cypress

Checklist

  • Commits follow our style guide
  • Related issues linked in commit messages if required
  • Screenshots are included in the PR if useful
  • All themes are supported if required
  • Unit tests added or updated if required
  • Cypress automation tests added or updated if required
  • Playwright automation tests added or updated if required
  • Storybook added or updated if required
  • Translations added or updated (including creating or amending translation keys table in storybook) if required
  • Typescript d.ts file added or updated if required
  • Related docs have been updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

N/A

Testing instructions

  • Run Help tests in Playwright Test Runner to check if the help.pw.tsx file passed
  • Run all other tests in Playwright Test Runner to check none of the other *.pw.tsx files have regressed

@divyajindel divyajindel requested review from a team as code owners September 14, 2023 12:56
@divyajindel divyajindel self-assigned this Sep 14, 2023
@divyajindel divyajindel marked this pull request as draft September 14, 2023 12:56
@divyajindel divyajindel force-pushed the help-playwright-refactor branch 3 times, most recently from 9a23d44 to 0b60633 Compare September 14, 2023 13:27
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 14, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fb392a0:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration

@divyajindel divyajindel marked this pull request as ready for review September 18, 2023 15:24
sianford
sianford previously approved these changes Sep 19, 2023
View reviewed changes
DipperTheDan
DipperTheDan reviewed Sep 22, 2023
View reviewed changes
src/components/help/help.pw.tsx Outdated
await mount(<HelpComponentTest tabIndex={tabIndex} />);

if (tabIndex === -1) {
await page.keyboard.press("Tab");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion(non-blocking): You should be able to move this tab presses and the one on line 136 outside of the if statement. As whether the tabIndex is -1, 0 or 1 you still need to press the tab key.

@divyajindel divyajindel merged commit bbf7a64 into master Sep 26, 2023
21 checks passed
@divyajindel divyajindel deleted the help-playwright-refactor branch September 26, 2023 09:12
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 120.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sianford sianford sianford approved these changes

@DipperTheDan DipperTheDan DipperTheDan approved these changes

Assignees

@divyajindel divyajindel

Labels
help Passed QA Passed Review playwright released Squad Front End
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@divyajindel @carbonci @sianford @DipperTheDan